Skip to content

Conversation

@ezhulenev
Copy link
Collaborator

@ezhulenev ezhulenev commented Dec 19, 2025

Add support for specifying NCCL version with nccl_version flag

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ezhulenev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the build script by adding support for specifying a hermetic NCCL version. This change provides greater control and flexibility for users who need to build with a particular NCCL version, ensuring consistency and reproducibility in their build environments.

Highlights

  • New Command-Line Argument: Introduced a new command-line argument, --nccl_version, to allow users to explicitly specify the hermetic NCCL version to be used during the build process.
  • Environment Variable Configuration: The provided --nccl_version is now used to set the HERMETIC_NCCL_VERSION environment variable, ensuring that the specified NCCL version is applied to the wheel build commands.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for specifying the NCCL version using a new --nccl_version flag. The implementation is consistent with how similar flags, like --cudnn_version, are handled. My review includes a couple of minor stylistic suggestions to remove trailing whitespace, adhering to PEP 8 guidelines.

@ybaturina ybaturina requested a review from hawkinsp December 19, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant