add a debug workflow

[jaxxstorm]

Important

Adds a Tailscale SSH debugging workflow and updates README with new features and usage instructions.

• New Workflow:
  • Adds ssh-debug.yml for Tailscale SSH debugging in .github/workflows/.
  • Supports multiple runner types (e.g., ubuntu-latest, macos-latest, windows-latest).
  • Configurable SSH session timeout and user authorization.
• README Updates:
  • Documents new SSH debugging workflow and its usage.
  • Highlights features like automatic cleanup, performance optimization, and cross-platform support.
  • Provides examples for authentication, ACL configuration, and advanced settings.

^{This description was created by for 228317c. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 228317c in 1 minute and 40 seconds. Click for details.

• Reviewed 569 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. .github/workflows/ssh-debug.yml:174

• Draft comment:
  Consider replacing the use of bc for calculating TIMEOUT_SECONDS with Bash arithmetic expansion if the input is guaranteed to be an integer. For example, use TIMEOUT_SECONDS=$((${inputs.timeout_minutes} * 60)) to simplify the code.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The suggestion would simplify the code by removing a pipe to bc. However, bc is more flexible with decimal numbers, while Bash arithmetic only handles integers. Looking at the workflow definition, timeout_minutes is defined as type "string" with a default of "30". There's no validation that it must be an integer. Using Bash arithmetic could break if someone enters a decimal value. The current code using bc is actually more robust since it handles decimal inputs. The suggestion could introduce bugs if users input decimal timeout values. While the suggestion would simplify the code, maintaining robustness with decimal inputs is more important than minor simplification. The current implementation using bc is actually better as it handles both integer and decimal inputs safely. The suggestion should be rejected.

2. README.md:50

• Draft comment:
  Consider adding a note about ensuring required dependencies (e.g., jq and bc) are available on the target runner, especially on non‐Linux platforms.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment suggests adding a note about ensuring dependencies are available, which falls under the category of asking the author to ensure something is done. This violates the rule against asking the author to ensure behavior is intended or tested.

Workflow ID: wflow_8bO6s7n3EAsEwl60

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}