Update to new tablewriter release #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tablewriter has changed a lot of formatting behavior. This commit tries to emulate the old behavior as much as possible. It may not be complete though.
This declutters html2text.go
… do all the configuration directly. The place for the configuration function is slightly odd, but avoids larger refactoring and possible breaking changes for consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tablewriter has changed a lot of formatting behavior. This PR tries to emulate the old behavior as much as possible. It may not be complete though. It also adds the possibility to bypass the legacy emulation layer completely and configure tablewriter to one's liking.
This fixes #67 .
Because the repository is still not enabled for Go modules (see #42), this PR does not include changes of the dependencies version.
For a version of the commits that include go.mod, please see the branch tw-update-gomod