Add support for building/running in Docker container#2
Open
dangirsh wants to merge 4 commits intojblomo:masterfrom
Open
Add support for building/running in Docker container#2dangirsh wants to merge 4 commits intojblomo:masterfrom
dangirsh wants to merge 4 commits intojblomo:masterfrom
Conversation
Owner
|
Thanks for your submission. I will try running on the new platform to
verify and accept when I get time this month. Cool to see this program
still being used!
…On Wed, Nov 29, 2017 at 5:24 PM, Dan ***@***.***> wrote:
Building Viewpoints on modern platforms is becoming increasingly
challenging. This PR adds support for compiling Viewpoints and all relevant
dependencies into an Ubuntu 14.04 Docker image. This corresponding
container has an entrypoint into the vp executable. Running the container
is done by:
> ./docker_vp.sh <vp args>
I've only tested this on Ubuntu 16.04, but I expect it to work on anything
that runs Docker.
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- Dockerize the main application
- Removed duplicate dockerfile
- Undo extraneous whitespace edits
- Removing unnecessary comment in dockerfile
File Changes
- *A* .dockerignore
<https://github.com/jblomo/viewpoints/pull/2/files#diff-0> (2)
- *M* INSTALL
<https://github.com/jblomo/viewpoints/pull/2/files#diff-1> (3)
- *A* blitz-patch.patch
<https://github.com/jblomo/viewpoints/pull/2/files#diff-2> (35)
- *A* docker/DOCKER_INSTALL
<https://github.com/jblomo/viewpoints/pull/2/files#diff-3> (19)
- *A* docker/Dockerfile
<https://github.com/jblomo/viewpoints/pull/2/files#diff-4> (91)
- *A* docker_vp.sh
<https://github.com/jblomo/viewpoints/pull/2/files#diff-5> (4)
- *A* inline_skating.csv
<https://github.com/jblomo/viewpoints/pull/2/files#diff-6> (29901)
- *M* plot_window.cpp
<https://github.com/jblomo/viewpoints/pull/2/files#diff-7> (2)
Patch Links:
- https://github.com/jblomo/viewpoints/pull/2.patch
- https://github.com/jblomo/viewpoints/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACwdbPOM2U3yUI0cys34JxXnwlb4mufks5s7gPJgaJpZM4Qv4u0>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building Viewpoints on modern platforms can be annoying/challenging. This PR adds support for compiling Viewpoints and all relevant dependencies into an Ubuntu 14.04 Docker image. This corresponding container has an entrypoint into the
vpexecutable. Running the container is done by:I've only tested this on an Ubuntu 16.04 host, but I expect it to work on anything that runs Docker.