Extended SupportsMultiModal

[Anexdeus]

Purpose

• Resolves the review in the vllm PR discussion

Test Plan

Test Result

---

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
• (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

[Anexdeus]

Hello,
I am here to help with the development of the feature Adding Lora on visual blocks of multimodal models
We track the progress of the development in our department and really hope this feature will be in the main branch asap

[jeejeelee]

@DarkLight1337 @Isotr0py @prashanth058 To avoid everyone changing things back and forth, what do you think - should the get_num_mm_encoder_tokens, get_num_mm_connector_tokens be implemented in processinfo or in model? I personally lean towards making them functions of model.

[prashanth058]

Agree. Since these methods are used for building LoRA mappings during execution rather than preprocessing, makes sense for get_num_mm_encoder_tokens, get_num_mm_connector_tokens to live on the model.

get_allowed_mm_limits should probably continue to live on the processinfo though?

[Anexdeus]

Sure! I have removed get_allowed_mm_limits().
I attempted to rewrite the logic in the model_runner files using that function, but it appears this issue has already been resolved

[DarkLight1337]

Same I also prefer implementing them on the model