Fix seeking to be relative to the current position #4937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syquel
force-pushed
the
bugfix/4427-relative-seeking
branch
4 times, most recently
from
a2cabfc to
9704d48
Compare
|
@nielsvanvelzen could you take a look, please? |
Syquel
force-pushed
the
bugfix/4427-relative-seeking
branch
from
9704d48 to
0255430
Compare
|
Don't ping for review requests, I look at stuff when I have time for it. Pushing to a PR will only move it lower on my backlog. |
Currently the available seek positions are fixed at multiples of the configured seek amount. Now seek positions are calculated relatively to the current position in increments of the configured seek amount. Fixes jellyfin#4427
Syquel
force-pushed
the
bugfix/4427-relative-seeking
branch
from
0255430 to
754b6bf
Compare
|
Didn't intend to offend, but just fixed issues I encountered on my dev build and added some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently the available seek positions are fixed at multiples of the configured seek amount.
Now seek positions are calculated relatively to the current position in increments of the configured seek amount.
Issues
Fixes #4427