Skip to content

Conversation

@genmad
Copy link
Contributor

@genmad genmad commented Apr 2, 2018

So this pull request is just for @znerd to test if it fulfills his requirements, in the moment . When this is done, we can discuss if and how to enable configurability of the feature that file properties are checked too.

So no need to merge anything yet. I will ping Oleg when we are done.

added Tests + implementation
@genmad
Copy link
Contributor Author

genmad commented Apr 2, 2018

Well,
it worked, at least on my Mac. So in the build pipeline on the windows machine, the tests for changed read and execute status failed.

Need to investigate further why. Is it a windows problem, or is it an java api problem, is it a timing problem? Changed the status read and execute but windows didn't update to the changes. Who knows ... Any suggestions are welcome.

@znerd sadly enough, my fears about this topic came true :(. On linux it seems to work, but on windows ...

@oleg-nenashev oleg-nenashev self-requested a review October 9, 2019 11:12
@znerd
Copy link
Contributor

znerd commented Mar 19, 2022

It's now almost 4 years later, and apparently I missed the notification for this PR. In the mean time, I've moved on, and I don't have a use case for this feature anymore.

Still, thanks a lot for the effort @genmad – and apologies for the late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants