Update WinProcess.java #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a detailed toString function to augment the default toString - ensuring the regular `toString()` function is not performing parsing tasks and gives the user the basic PID information only. If the user desires a detailed toString, they can use `toStringDetailed()` Feel free to pick this apart or change my strategy. I'm not sure if the `String.format` function also is slower than using the `".." + ".."` style of string concatenation which is employed now in the code. I just find the printf style to be more readable.
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Some Javadoc could be usefil, but fine with me. Note that the new method may throw WinpException
Member
|
Will get it landed in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a detailed toString function to augment the default toString - ensuring the regular
toString()function is not performing parsing tasks and gives the user the basic PID information only.If the user desires a detailed toString, they can use
toStringDetailed()Feel free to pick this apart or change my strategy. I'm not sure if the
String.formatfunction also is slower than using the".." + ".."style of string concatenation which is employed now in the code. I just find the printf style to be more readable.