Skip to content

fix: resolve symlinks for pnpm windows bundle #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve symlinks for pnpm windows bundle #192

wants to merge 1 commit into from

Conversation

@bestickley
Copy link
Contributor

@bestickley bestickley commented Dec 28, 2023 •
edited
Loading

Fixes #183.

Key comment from code:

// Compress-Archive doesn't support resolving symlinks like `zip` command
// does with -y option. Therefore, we need to resolve symlinks then compress.

@bestickley bestickley requested a review from revmischa December 28, 2023 15:32
@bestickley bestickley mentioned this pull request Dec 28, 2023
Closed
@bestickley bestickley changed the title fix: remove symlinks for pnpm windows bundle fix: resolve symlinks for pnpm windows bundle Dec 28, 2023
@revmischa
Copy link
Member

revmischa commented Feb 22, 2025

Cool! Please resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@revmischa revmischa revmischa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix: Usage with PNPM on Windows

3 participants

@bestickley @revmischa