-
Notifications
You must be signed in to change notification settings - Fork 0
Fix systemd service #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfhbrook
commented
Feb 7, 2025
| async def load() -> None: | ||
| client = DbusClient() | ||
| ctx.obj = Obj(client=client, log_level=log_level, output=output) | ||
| bus: SdBus = sd_bus_open_user() if user else sd_bus_open_system() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured out that the default bus is the system bus when started with a non-user systemd unit: https://www.freedesktop.org/software/systemd/man/latest/sd_bus_default.html based on me being able to get past a "where is the bus tho" error, I seem to understand this correctly.
jfhbrook
commented
Feb 7, 2025
jfhbrook
commented
Feb 7, 2025
jfhbrook
commented
Feb 7, 2025
jfhbrook
commented
Feb 7, 2025
jfhbrook
commented
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The systemd service is currently broken. This branch fixes the systemd unit, and makes progress towards full functionality.
The good news is that the service starts:
I can also manage the plusdeck with
plusdeckctlusingsudo.However, unprivileged access is eluding me. The intent is that unprivileged users in the
plusdeckgroup may have full access to the service. Currently what works is listening to signals (plusdeckctl subscribe), as well as property access (plusdeckctl config show). Unfortunately, method calling (plusdeckctl eject) is not working.I believe the issue lies with systemd, either with some capacities I have to manually set, or with some settings I need in polkit. For more information, see these discussion threads:
My intent is to merge and release this as-is, and delegate fixing unprivileged access to a secondary ticket and PR.