Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Django upgrade to v4+ causes some CSRF-related issues resulting in calls to backend getting access denied. Updated certian settings files appropriately. Also restores old docker-compose.yml, fixes linter error, and fixes logout issue due to depreciated Django view.
🔍 Change Log
semesterly/settings.py: addedCSRF_TRUSTED_ORIGINSstatic/js/redux/ui/modals/UserSettingsModal.tsx: updates from link-click to a POST request. a clicked link results in a GET request to the LogoutView, which is depreciated in Django v5+student/views.py: makes custom logout view in accordance with LogoutView depreciation. see docs for updated instructionsstudent/urls.py: updates url with new logout viewdocker-compose.yml: restores certain parts of this file to match previous docker-compose indevelopstatic/js/redux/ui/modals/UserSettingsModal.tsx: runs prettierPlease fill in the following required testing steps with a checkbox (✅) before making this PR, or indicate why they are not necessary for this change:
[✅]
docker-compose build && docker-compose upand thehttps://jhu.sem.lyendpoint works successfully[✅] Semesterly CI successful
[✅] Backend linter successful
[✅] TSLint successful
💻 Local Testing Instructions
To test locally from a forked repo, run:
Please contact the owner of the fork in case the fork's branches are not publically accessible.