Add handler for availability check of ionic-native #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasMerz
force-pushed
the
ionic-native
branch
from
f8f92b6 to
b121f94
Compare
Function was nicer but did break the hander at the start of the app
Collaborator
|
Hi Niklas, can you provide a reference that ionic-native prohibits to call a function in case it was assigned dynamically? I will check why travis buidl fails .. shouldn't be related to your change. Probably next week I can do a new release containing your change |
Contributor
Author
|
Thank you very much. No need to hurry. I think I even copied the link, but I forgot to add it to the PR. Here is the check in the |
Contributor
Author
|
I added cordova paramedic to some other plugins before. I could help with the failing build. |
Contributor
Author
|
I just found this PR again. Can I do somthing to get this merged and into a new version of the plugin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 5 of ionic-native the
onItemPressedhandler did not work anymore. I found out that ionic-native now checks if the function to be overwritten is existing. That's why this PR adds a dummy.