Added support for driving the aux-spi port. #146
Open
MarkvanderPol wants to merge 1 commit intojperkin:masterfrom
Open
Added support for driving the aux-spi port. #146MarkvanderPol wants to merge 1 commit intojperkin:masterfrom
MarkvanderPol wants to merge 1 commit intojperkin:masterfrom
Conversation
primary port equivalents and changed their name. Added the flag WORKER_ENABLED to permit running in newer NODE releases easier, but I have not verified if the code can actully do multi-threading. A quick glance indicates most register access are benign, but if two processes seperately start to access a SPI port results may be suprising.
Owner
|
Hey, just want to say thanks for doing this! Sorry it's taking me a while to review but things have been busy, I'll try to get to it as soon as I can. |
|
Any plan to merge this? I've got a project needing to use both SPI ports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly copied the primary port equivalents and changed their name.
Added the flag WORKER_ENABLED to permit running in newer NODE
releases easier, but I have not verified if the code can actually
do multi-threading. A quick glance indicates most register
access are benign, but if two processes separately start to access
a SPI port results may be surprising.