Skip to content

Get build for Intel macOS working #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacksongoode merged 4 commits into from
Dec 20, 2025
Merged

Get build for Intel macOS working #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10f44db
Reorder steps and write with the universal version
jacksongoode Nov 23, 2025
0e68ee1
Explicitly target older mac and with intel runner?
jacksongoode Dec 19, 2025
547d738
Quiet brew, clean up bundle, proper paths
jacksongoode Dec 19, 2025
49d8032
Cleanup
jacksongoode Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ jobs:
path: |
~/.cargo/bin/cargo-bundle
~/Library/Caches/Homebrew
/usr/local/Cellar/create-dmg
key: ${{ runner.os }}-tools-${{ hashFiles('**/Cargo.lock', '.github/workflows/build.yml') }}
restore-keys: |
${{ runner.os }}-tools-
Expand All @@ -101,45 +100,46 @@ jobs:
run: cargo install cargo-bundle

- name: Install create-dmg
if: runner.os == 'macOS' && !steps.cache-tools.outputs.cache-hit
run: brew install create-dmg
if: runner.os == 'macOS'
run: brew install -q create-dmg

- name: Create macOS universal binary
if: runner.os == 'macOS'
run: |
mkdir -p psst-gui/target/release
lipo -create -output psst-gui/target/release/psst-gui \
target/x86_64-apple-darwin/release/psst-gui \
target/aarch64-apple-darwin/release/psst-gui
mkdir -p target/release
lipo -create \
-arch x86_64 target/x86_64-apple-darwin/release/psst-gui \
-arch arm64 target/aarch64-apple-darwin/release/psst-gui \
-output target/release/psst-gui

- name: Bundle macOS Release
if: runner.os == 'macOS'
run: cargo bundle --release
working-directory: psst-gui
env:
CARGO_BUNDLE_SKIP_BUILD: "true"
run: |
cargo bundle --release -p psst-gui

- name: Create DMG
if: runner.os == 'macOS'
run: |
brew install create-dmg
create-dmg \
--volname "Psst" \
--volicon "assets/logo.icns" \
--volicon "psst-gui/assets/logo.icns" \
--window-pos 200 120 \
--window-size 600 400 \
--icon-size 100 \
--icon "Psst.app" 150 160 \
--hide-extension "Psst.app" \
--app-drop-link 450 160 \
"Psst.dmg" \
"../target/release/bundle/osx/Psst.app"
working-directory: psst-gui
"target/release/bundle/osx/Psst.app"

- name: Upload macOS DMG
uses: actions/upload-artifact@v4
if: runner.os == 'macOS'
with:
name: Psst.dmg
path: ./psst-gui/Psst.dmg
path: Psst.dmg

- name: Make Linux Binary Executable
if: runner.os == 'Linux'
Expand Down
1 change: 1 addition & 0 deletions psst-gui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ name = "Psst"
identifier = "com.jpochyla.psst"
icon = ["assets/logo.icns"]
version = "0.1.0"
osx_minimum_system_version = "11.0"
resources = []
copyright = "Copyright (c) Jan Pochyla 2024. All rights reserved."
category = "Music"
Expand Down