ISOServer: catch BindException #660
Merged
+36
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ISOServerwas unable to bind to the server port, it was catching a genericThrowableand generating a generic jPOSThrowableAuditLogEvent.Also, a one-liner of the exception was being logged as
info, but with no clue as to which port failed.This PR
org.jpos.log.evt.Listenwith a possibleerrormessage (unrendered ifnull)BindExceptionListenjPOS event that is thrown in the successful case (when bind succeeds), but with anerrormessage (and inside awarnLogEventinstead of aninfo).This has two advantages:
Listenevent already carries port number, bind address, etc.BaseChannelwhich uses theConnectevent both in the succesful and failed case, giving anerrorin the second case.This is an example in the traditional jPOS log format when it fails
The
round(indicating attempt) was added for extra info, because the variable was available and not being used ;-)This has also been tested with structured logging and it looks fine. For example (pretty printed)
{ "ts": "2025-12-26T22:11:43.849597Z", "realm": "xyz.server", "tag": "warn", "trace-id": "1b1406f246b74053b4240fd8c01a5712", "evt": [ { "t": "listen", "port": 2324, "bindAddr": "localhost", "permits": 100, "backlog": 5, "error": "(round 14) java.net.BindException: Address already in use" } ] }