Improvements to retry middleware #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on merging this improvement? |
|
any updates on this? |
…se on EnqueueWithOptions
Enqueue jobs in multiple redis instances
stats refactor to return struct
- Use log levels (fatal, debug, error, info and warn) - Allow structured logging (uses logrus by default) - Change logging middleware logs to debug - A few tweaks in some log messages, specially errors
tkuchiki
added a commit
to tkuchiki/go-workers
that referenced
this pull request
Aug 25, 2020
|
any update about it ? |
* Update project setup * Update deprecated Redis package to the new one * Change the worker configuration options * Adjust test to improve logs traceability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some improvements to the retry middleware implemented.
RetryOptionsstruct inEnqueueOptionsRetryMaxfield: even thoughRetrycan be either a bool or an int (when processing the job), theEnqueueOptionsstruct specifies it as a bool, so the maximum number of retries is always set to the default value of 25.RetryMaxfield allows specifying a custom maximum number of retries.