Allow Config to be initialized without using Configure #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix tests so that they pass on go1.11.1
For example so that we an use redis over a TLS connection, and that configuration requires more than just strings in a map.
tkuchiki
added a commit
to tkuchiki/go-workers
that referenced
this pull request
Aug 24, 2020
tkuchiki
added a commit
to tkuchiki/go-workers
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example so that we can use Redis over a TLS connection, and that configuration requires more than just strings in a map.
This PR also updates
github.com/garyburd/redigo/redistogithub.com/gomodule/redigo/redis, and fixes the ManagerSpec so that it passes on go1.11.1.