Skip to content

Feature/create block external templates #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Feature/create block external templates #8

wants to merge 20 commits into from

Conversation

@fabiankaegy
Copy link
Member

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

fabiankaegy and others added 19 commits April 30, 2020 14:47
@fabiankaegy
initial working implementation
48c7ee1
@fabiankaegy
cleanup functions
14611a3
@fabiankaegy
fix getPrompts
3714b20
@fabiankaegy
fix improve error message
b0b617f
@fabiankaegy
add template to prompts
e81dd27
@fabiankaegy
fix remove unneccecary call of checkIsCoreTemplate
db93598
@fabiankaegy
add documentation for external package support
4b55cdf
@fabiankaegy
fix linting errors
62811e3
@fabiankaegy
fix suggetions from @gziolo
11072bf
@fabiankaegy
remove template from prompts
7036078
@fabiankaegy
fix use correct temp folder across the board
4b0b246
@fabiankaegy
fix remove temp folder after done with scaffold
86f7327
@fabiankaegy
fix hasWPScriptsEnabled to be async
083a990
@fabiankaegy
fix has wpScriptsEnabled
ea9dc1b
@fabiankaegy @aduth
Update packages/create-block/lib/templates.js
5be44cc 
Co-authored-by: Andrew Duthie <[email protected]>
@fabiankaegy @aduth
Update packages/create-block/README.md
22cdbb3 
Co-authored-by: Andrew Duthie <[email protected]>
@fabiankaegy @aduth
Update packages/create-block/README.md
fac8b18 
Co-authored-by: Andrew Duthie <[email protected]>
@fabiankaegy
fix typos
0a7169e
@fabiankaegy
fix spelling of overridden
06a3051
@intelijens intelijens mentioned this pull request Jun 19, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjadeubzer anjadeubzer Awaiting requested review from anjadeubzer

@brezocordero brezocordero Awaiting requested review from brezocordero

@intelijens intelijens Awaiting requested review from intelijens

@jessynd jessynd Awaiting requested review from jessynd

@rbest rbest Awaiting requested review from rbest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabiankaegy