Add support for EdDSA #457
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecsammon
commented
Jan 8, 2025
| /** | ||
| * @var mixed holds well-known openid configuration parameters, like policy for MS Azure AD B2C User Flow | ||
| * @see https://docs.microsoft.com/en-us/azure/active-directory-b2c/user-flow-overview | ||
| * @see https://docs.microsoft.com/en-us/azure/active-directory-b2c/user-flow-overview |
alecsammon
commented
Jan 8, 2025
| $protocol = 'http'; | ||
| } | ||
|
|
alecsammon
commented
Jan 8, 2025
|
|
||
| $port = (443 === $port) || (80 === $port) ? '' : ':' . $port; | ||
|
|
DeepDiver1975
requested changes
Mar 3, 2025
Collaborator
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
Please add a unit test for this - THX
Author
|
@DeepDiver1975 - thanks - I've added test cases for the EdDSA key :) |
| throw new OpenIDConnectClientException('Malformed key object'); | ||
| } | ||
|
|
||
| if (!function_exists("sodium_crypto_sign_verify_detached")) { |
Collaborator
There was a problem hiding this comment.
This can be handled via composer as well. Please adjust composer.json and add
"ext-sodium": "*",
This was referenced Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of common tasks a pull request require complete
Adds support for
EdDSA/Ed25519