-
Notifications
You must be signed in to change notification settings - Fork 372
Centralize app cleanup #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should hopefully pass now that |
23e3288 to
a48e2f5
Compare
7c62a6d to
726948f
Compare
Codecov Report
@@ Coverage Diff @@
## main #792 +/- ##
==========================================
+ Coverage 69.96% 69.99% +0.02%
==========================================
Files 62 62
Lines 7368 7355 -13
Branches 1223 1225 +2
==========================================
- Hits 5155 5148 -7
+ Misses 1841 1835 -6
Partials 372 372
Continue to review full report at Codecov.
|
|
Wow, this is awesome. So much cleaner than before. Thank you, @blink1073! |
|
Great stuff. |
|
@meeseeksmachine please backport to 1.x. |
|
@meeseeksdev please backport to 1.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Potentially fixes #790
Depends on jupyter/jupyter_client#772
TODO:
stop_extensionjp_cleanup_subprocessesjupyter_clientwith Fix shutdown and cleanup behavior jupyter/jupyter_client#772