Fix vi input mode enum bug #289
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
vioptionsspecified in
jupyter_console_config.py, the terminal output, in allvimodes, looks like:The reason for the error is found here.
The
Enumself.pt_cli.app.vi_state.input_modeis passed into thestrfunction, which only shows the the enum name and member name, not the value of the member, cf the Python docs.The
Enumused is theInputMode.INSERTEnumfromprompt_toolkitdefined here.Applying the
strfunction returnsInputMode.INSERTand subsetting this with[3:6]yields theutMshown in the terminal screenshot.This pull requests fixes this issue by simply removing the application of the
strfunction before subsetting the enum member. This is also what is done in theIPythonrepo here.