Updating to MathJax 3 #1691
Open
Updating to MathJax 3 #1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
- This pr starts to update the nbconvert app to use MathJax 3.
MathJax 3 does not use inline script execution to pull in its
libraries which improves the security story for using this library.
|
I temporarily update our app to use this branch and everything looks good. But you probably want to kick the tires yourself a bit 😅 |
|
Thanks! Will try to review and get this in for 6.5. |
|
Of note, we are upgrading to MathJax 3 on JupyterLab side too: jupyterlab/jupyterlab#13877. It would be nice to land both PRs at similar time for consistency. |
|
Note that MathJax 4 will ship soon 🤞, thought this release should be much more backwards compatible than the 2 → 3 transition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
MathJax 3 does not use inline script execution to pull in its
libraries which improves the security story for using this library.
Notes:
This needs some solid testing, I have yet to build a bunch of notebooks with it, although the config is based on the MathJax setup we are using at GitHub for Notebook viewing. We hope to upstream this so it can be tweaked and owned by the community and not us.
For what its worth, Reveal 4.0 introduces a MathJax plugins so I think if that was updated there could be some custom code removed as well. https://github.com/hakimel/reveal.js/releases https://618b8dc985f599ad10a72ac4--revealjs.netlify.app/math/#mathjax-3-4.2.0