Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Feb 5, 2025

To fix the currently failing CI:

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@jtpio jtpio added the maintenance Packaging, tests label Feb 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Binder 👈 Launch a Binder on branch jtpio/jupyter-chat/fix-upload-artifact

@jtpio
Copy link
Member Author

jtpio commented Feb 5, 2025

Looks like the mypy failures may likely be fixed by #150.

@jtpio jtpio changed the title Update to actions/upload-artifact@v4 Update to actions/upload-artifact@v4 and actions/download-artifact@v4 Feb 5, 2025
@jtpio
Copy link
Member Author

jtpio commented Feb 5, 2025

Merging as this already helps fix CI with the two deprecated actions.

@jtpio jtpio merged commit 3ebff19 into jupyterlab:main Feb 5, 2025
12 of 13 checks passed
@jtpio jtpio deleted the fix-upload-artifact branch February 5, 2025 08:49
@brichet
Copy link
Collaborator

brichet commented Feb 6, 2025

Looks like the mypy failures may likely be fixed by #150.

Yes, this test was not consistent and was passing sometime, with the same version of mypy it seems.
Indeed, it should be solved now, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Packaging, tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants