Allow use of up and down arrow in chat input #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
jtpio
approved these changes
Feb 10, 2025
Member
jtpio
left a comment
jtpio
left a comment
There was a problem hiding this comment.
Thanks!
Just tried locally and it works fine now:
jupyter-chat-up-down-arrow.mp4
We can always revisit the implementation alter if there is a better pattern or option to solve this.
Collaborator
Author
|
cc. @dlqqq to port it to |
Member
|
Thanks! I've assigned it to a new member on our team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
This PR prevent propagating the up and down arrow event to the
Autocompletecomponent if the autocompletion is not opened.It is weird that it is not handled by material UI itself, maybe there is a better solution.