Skip to content

Conversation

@andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Jul 24, 2025

References

In JupyterLab, the launcher closes when you create a new document on widget from it. Basically, the new doc replaces the launcher. In Jupyter Chat, when you create a chat file from the launcher, the launcher stays open.

Code changes

Returns docmanager widget from createChat/openChat commands to ensure proper launcher disposal.

User-facing changes

New chats created in main area replace launcher.

Backwards-incompatible changes

None.

Before this PR:
Kapture 2025-07-24 at 15 14 08-2

After this PR:
tab_replaced

@andrii-i andrii-i added the enhancement New feature or request label Jul 24, 2025
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch andrii-i/jupyter-chat/close-launcher

Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brichet
Copy link
Collaborator

brichet commented Jul 25, 2025

Good catch, thanks @andrii-i

@brichet brichet merged commit 26c9be2 into jupyterlab:main Jul 25, 2025
14 of 15 checks passed
@andrii-i andrii-i deleted the close-launcher branch July 25, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JupyterLab launcher stays open when creating chat file from launcher

3 participants