-
-
Notifications
You must be signed in to change notification settings - Fork 20
Making files dragable and dropable from TabBar. #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Cross reference to jupyterlite/ai#236, where this issue as first been discussed. |
brichet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nakul-py, looks nice.
I only have some comments about typing.
The suggestions cannot be applied as it, there will be some issue with import. Also it may be useful to add the packages in the dependencies if they are not already there.
|
Thanks @nakul-py, looks like the dependencies are missing from package.json file (and yarn.lock). ...
"@jupyterlab/docregistry": "^4.2.0",
...
"@lumino/widgets": "^2.0.0",Then you'll need to run |
@brichet We already have these dependencies in |
Looks like not jupyter-chat/packages/jupyter-chat/package.json Lines 45 to 70 in fbcdf8d
|
Ohh by mistake i have seen in
I think we have to manually add dependencies. |
brichet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nakul-py 🎉
This PR makes files dragable and dropable from TabBar into the chat.
Screencast.From.2025-12-08.18-55-44.mp4
This enhancement is done with the help of @brichet ❤️