Skip to content

Conversation

@nakul-py
Copy link
Contributor

@nakul-py nakul-py commented Dec 8, 2025

This PR makes files dragable and dropable from TabBar into the chat.

Screencast.From.2025-12-08.18-55-44.mp4

This enhancement is done with the help of @brichet ❤️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Binder 👈 Launch a Binder on branch nakul-py/jupyter-chat/tabbar

@brichet brichet added the enhancement New feature or request label Dec 8, 2025
@brichet
Copy link
Collaborator

brichet commented Dec 8, 2025

Cross reference to jupyterlite/ai#236, where this issue as first been discussed.

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nakul-py, looks nice.

I only have some comments about typing.
The suggestions cannot be applied as it, there will be some issue with import. Also it may be useful to add the packages in the dependencies if they are not already there.

@nakul-py nakul-py requested a review from brichet December 12, 2025 11:01
@brichet
Copy link
Collaborator

brichet commented Dec 12, 2025

Thanks @nakul-py, looks like the dependencies are missing from package.json file (and yarn.lock).
We should probably add the following dependency in packages/jupyter-chat/package.json:

...
"@jupyterlab/docregistry": "^4.2.0",
...
"@lumino/widgets": "^2.0.0",

Then you'll need to run jlpm install, maybe test that it builds, and push the changes if everything is fine.

@nakul-py
Copy link
Contributor Author

We should probably add the following dependency in packages/jupyter-chat/package.json:

...
"@jupyterlab/docregistry": "^4.2.0",
...
"@lumino/widgets": "^2.0.0",

@brichet We already have these dependencies in packages/jupyter-chat/package.json.

@brichet
Copy link
Collaborator

brichet commented Dec 12, 2025

We already have these dependencies in packages/jupyter-chat/package.json.

Looks like not

"dependencies": {
"@emotion/react": "^11.10.5",
"@emotion/styled": "^11.10.5",
"@jupyter/react-components": "^0.15.2",
"@jupyterlab/application": "^4.2.0",
"@jupyterlab/apputils": "^4.3.0",
"@jupyterlab/codeeditor": "^4.2.0",
"@jupyterlab/codemirror": "^4.2.0",
"@jupyterlab/docmanager": "^4.2.0",
"@jupyterlab/filebrowser": "^4.2.0",
"@jupyterlab/fileeditor": "^4.2.0",
"@jupyterlab/notebook": "^4.2.0",
"@jupyterlab/rendermime": "^4.2.0",
"@jupyterlab/ui-components": "^4.2.0",
"@lumino/algorithm": "^2.0.0",
"@lumino/commands": "^2.0.0",
"@lumino/coreutils": "^2.0.0",
"@lumino/disposable": "^2.0.0",
"@lumino/polling": "^2.0.0",
"@lumino/signaling": "^2.0.0",
"@mui/icons-material": "^7.3.2",
"@mui/material": "^7.3.2",
"clsx": "^2.1.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},

@nakul-py
Copy link
Contributor Author

nakul-py commented Dec 12, 2025

Looks like not

Ohh by mistake i have seen in

"@jupyterlab/docregistry": "^4.2.0",

I think we have to manually add dependencies.

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nakul-py 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants