Skip to content

Conversation

@mdevolde
Copy link
Collaborator

@mdevolde mdevolde commented Nov 20, 2025

fix (test_api_public): patched a bug in API test (get request freezed)

Why the pull request was made

To prevent the CI from failing when the library code is compliant.

Summary of changes

  • Added the ability to manually rerun the CI
  • Removed usage of pytest-xdist (cause of inconsistency in the CI)
  • Removed unused packages pytest-xdist, pytest-rerunfailures and pytest-runner in the group "tests"
  • Removed previous fix applied to the 'API test' with env var and previous fix applied to a match test (rerun)

Screenshots (if appropriate):

Not applicable.

How has this been tested?

Made CI executions on my fork.

Resources

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation only)
  • Refactor / code style update (non-breaking change that improves code structure or readability)
  • Tests / CI improvement (adding or updating tests or CI configuration only)
  • Other (please describe):

Checklist

  • Followed the project's contributing guidelines.
  • Updated any relevant tests.
  • Updated any relevant documentation.
  • Added comments to your code where necessary.
  • Formatted your code, run the linters, checked types and tests.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a test freeze issue in the public API test by implementing a timeout mechanism and adjusting CI configuration. The test was previously skipped on CI due to potential freezing issues, but now runs with proper timeout protection.

  • Removed the CI skip marker from test_api_public.py to allow the test to run in CI environments
  • Implemented a timeout wrapper using concurrent.futures.ThreadPoolExecutor to prevent test hangs
  • Changed pytest parallelization from auto workers to single worker to avoid concurrency conflicts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tests/test_api_public.py Refactored test to use timeout wrapper with concurrent.futures, removed CI skip marker, and improved exception handling
.github/workflows/test.yml Added manual workflow trigger and changed pytest workers from auto to 1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Repository owner deleted a comment from Copilot AI Nov 22, 2025
Repository owner deleted a comment from Copilot AI Nov 22, 2025
@mdevolde
Copy link
Collaborator Author

Finally removed pytest-xdist to resolve the issue, without any other needed fix.

@mdevolde mdevolde merged commit a1be9b5 into jxmorris12:master Nov 22, 2025
8 checks passed
@mdevolde mdevolde deleted the CI_BUG branch November 22, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant