Skip to content

Conversation

@mdevolde
Copy link
Collaborator

feat: added possibility to use proxies in LanguageTool requests, updated uv.lock

Why the pull request was made

To resolve the issue mentioned in this issue: #70

Summary of changes

  • Added an optional parameter to LanguageTool (proxies)
  • Added an attribute to LanguageTool
  • This attribute is used by the _query_server method
  • Updated uv.lock (to keep it up to date with tests deps removal in previous PR)

Screenshots (if appropriate):

Not applicable.

How has this been tested?

Tested with a local proxy (dedicated to these tests). Also applied local tests.

Resources

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation only)
  • Refactor / code style update (non-breaking change that improves code structure or readability)
  • Tests / CI improvement (adding or updating tests or CI configuration only)
  • Other (please describe):

Checklist

  • Followed the project's contributing guidelines.
  • Updated any relevant tests.
  • Updated any relevant documentation.
  • Added comments to your code where necessary.
  • Formatted your code, run the linters, checked types and tests.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds proxy support for LanguageTool remote server requests and updates the uv.lock file to reflect test dependency removals from a previous PR. The proxy functionality allows users to route their LanguageTool API requests through HTTP/HTTPS proxies, with validation ensuring proxies are only used with remote servers.

  • Added optional proxies parameter to LanguageTool.__init__ with validation
  • Implemented proxies property with getter/setter for runtime configuration
  • Integrated proxy support into _query_server method for all server requests

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
uv.lock Removed test dependencies (pytest-rerunfailures, pytest-runner, pytest-xdist, execnet) that were deleted in a previous PR
language_tool_python/server.py Added proxy support parameter, attribute, property accessor/mutator, validation logic, and integration with requests library

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mdevolde mdevolde merged commit c165fae into jxmorris12:master Nov 22, 2025
14 checks passed
@mdevolde mdevolde deleted the proxies branch November 22, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant