docs: update local build instructions #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add make download-assets step for artifact preparation - Update docker build to use buildx with platform specification - Add required ARTIFACT=k3s build argument - Update example version from v1.17.2 to v1.33.5+k3s1 throughout - Fix repository reference from k3s-io to rancher - Document environment variables (ARCH, TAG, VERSION, REPO) - Add artifacts/ to .gitignore to exclude downloaded binaries - Update Plan example version for consistency Signed-off-by: hammadsaedi <[email protected]>
hammadsaedi
force-pushed
the
docs/update-local-build-instructions
branch
from
7a34e3c to
292c75f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates local build instructions in
README.mdwith correct commands and environment setup needed to successfully build the k3s-upgrade image.Changes
docker buildwithdocker buildx buildincluding platform specificationmake download-assetsstep to download k3s binaries--build-arg ARTIFACT=k3sparameterk3s-iotorancher(proper upstream)artifacts/directory created bymake download-assetsTest Plan
make download-assetsproperly downloads k3s artifacts toartifacts/directorydocker buildx buildcompletes without errors using updated parameters