-
Notifications
You must be signed in to change notification settings - Fork 358
Allow configuration of max payload size limit #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
164c023
Allow configuration of max payload size for a2a
kevin-shelaga c868ecc
lint format
kevin-shelaga 84a572f
Address copilot comments
kevin-shelaga 8385e02
Address copilot comments
kevin-shelaga 7c55825
Merge branch 'payload-limit' of https://github.com/kevin-shelaga/kage…
kevin-shelaga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
go/internal/controller/translator/agent/testdata/inputs/agent_with_max_payload_size.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| operation: translateAgent | ||
| targetObject: test-agent | ||
| namespace: test | ||
|
|
||
| objects: | ||
| - apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: openai-secret | ||
| namespace: test | ||
| data: | ||
| api-key: c2stdGVzdC1hcGkta2V5 # base64 encoded "sk-test-api-key" | ||
| - apiVersion: kagent.dev/v1alpha2 | ||
| kind: ModelConfig | ||
| metadata: | ||
| name: default-model-config | ||
| namespace: test | ||
| spec: | ||
| provider: OpenAI | ||
| model: gpt-4o | ||
| apiKeySecret: openai-secret | ||
| apiKeySecretKey: api-key | ||
| defaultHeaders: | ||
| User-Agent: "kagent/1.0" | ||
| - apiVersion: kagent.dev/v1alpha2 | ||
| kind: Agent | ||
| metadata: | ||
| name: test-agent | ||
| namespace: test | ||
| spec: | ||
| type: Declarative | ||
| description: Agent with max payload size configuration | ||
| declarative: | ||
| modelConfig: default-model-config | ||
| systemMessage: You are a helpful assistant. | ||
| a2aConfig: | ||
| maxPayloadSize: "50Mi" | ||
| tools: [] | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144 changes: 144 additions & 0 deletions
144
python/packages/kagent-adk/tests/unittests/test_a2a_payload_size.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,144 @@ | ||||
| # Copyright 2025 Google LLC | ||||
| # | ||||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||||
| # you may not use this file except in compliance with the License. | ||||
| # You may obtain a copy of the License at | ||||
| # | ||||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||||
| # | ||||
| # Unless required by applicable law or agreed to in writing, software | ||||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||
| # See the License for the specific language governing permissions and | ||||
| # limitations under the License. | ||||
|
|
||||
| """Unit tests for A2A payload size configuration. | ||||
|
|
||||
| NOTE: These tests verify that the configuration value can be set and patched, | ||||
| but do NOT verify end-to-end behavior (i.e., that payloads of the configured | ||||
| size can actually be sent/received). | ||||
| """ | ||||
|
|
||||
| from unittest import mock | ||||
|
|
||||
| import pytest | ||||
|
|
||||
|
Comment on lines
+24
to
+25
|
||||
| import pytest |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extracted
maxPayloadSizeBytesvalue is not validated before being assigned to the config. While Kubernetes resource.Quantity parsing handles invalid formats, it can accept negative values (e.g., "-10Mi"). Consider adding validation to ensure the value is positive before assigning it tocfg.MaxPayloadSize.