Optional Maintenance Mode #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… minimal layout gating via env flags
giorgiobrullo
requested changes
Sep 22, 2025
Comment on lines
+64
to
+70
| // Post-maintenance loading stages | ||
| const postMaintenanceStages = [ | ||
| 'Finalizing updates...', | ||
| 'Restarting services...', | ||
| 'Loading application...', | ||
| 'Almost ready...' | ||
| ]; |
Collaborator
There was a problem hiding this comment.
These should be localized in en.json
| <div class="mx-auto mb-4 h-24 w-24"> | ||
| {#if theme.current === 'dark'} | ||
| <!-- Dark theme logo --> | ||
| <svg width="100%" height="100%" viewBox="0 0 146 162" class="h-full w-full" class:animate-bounce={!isMaintenanceComplete} class:brightness-75={false} class:sepia={false} class:hue-rotate-[320deg]={false} class:saturate-150={false}> |
Collaborator
There was a problem hiding this comment.
this svg is duplicated/should be external, not hardcoded like this in the HTML.
| {#if isMaintenanceComplete} | ||
| <div class="mt-4 text-center"> | ||
| <p class="text-green-600 dark:text-green-400 font-medium"> | ||
| Systems are back online |
Collaborator
There was a problem hiding this comment.
more strings that need i18n
| isActive, | ||
| status, | ||
| progress, | ||
| timeRemaining, |
Collaborator
There was a problem hiding this comment.
We don't need to send this timeRemaining string in the API, clients can just build this themselves.
| ); | ||
| // Minimal maintenance gating derived from server-provided flags and PUBLIC env | ||
| const maintenanceActive = $derived.by(() => { |
Collaborator
There was a problem hiding this comment.
I am not sure why we are deriving things again from public env, when we do this in the server.ts? we should do it in a single place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional maintenance mode that can run manually or automatically depending on
.envFollowing settings are supported:
.envThese are supported in
.env