Optimize PostgreSQL tests with shared container #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add sharedPostgresContainer struct with sync.Once for single container startup - Implement CreateDatabase/DropDatabase for per-test database isolation - Update postgresTestSetup to use shared container instead of per-test containers - Add goleakOptions to ignore testcontainers Reaper goroutine - Update all test files to use goleakOptions
- Handle conn.Close error returns in defer statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Optimize PostgreSQL test performance by starting a single container once per
go testrun viaTestMain, rather than starting/stopping a container for each test function. This reduces test overhead from ~20-40+ seconds to ~3-7 seconds while maintaining complete test isolation via separate databases.Implementation
sharedPostgresContainerstruct withsync.Onceto ensure single container startup per test runCreateDatabase/DropDatabasemethods that create unique databases (querator_test_1,querator_test_2, etc.) within the shared containerpostgresTestSetup.Setup()to create a new database instead of starting a containerpostgresTestSetup.Teardown()to drop the database instead of terminating the containergoleakOptionsto ignore testcontainers Reaper goroutine across all test files