Cleanup: Remove dead code and stale TODOs #59
Merged
+409
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove stale TODO comments from partition_test.go and queue_test.go - Add implementation plan for shared PostgreSQL container optimization
The retry flag was defined but never implemented. Retry items and scheduled items are functionally identical (both use EnqueueAt field), so the scheduled flag already handles clearing retry items. - Remove retry field from QueueClearRequest proto message - Remove Retry field from internal ClearRequest type - Update validation to check only queue and scheduled flags - Update comments to clarify scheduled includes retry items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Clean up dead code and stale TODO comments from the codebase. This removes the unimplemented retry flag from QueueClear and cleans up outdated TODO comments in test files.
Implementation
retryflag fromQueueClearRequestproto and internal types - it was never implemented and retry items are functionally identical to scheduled items (both useEnqueueAt)logical.goto only checkqueueandscheduledflagsscheduledflag clears retry itemspartition_test.goandqueue_test.go