feat: expose and secure controller-runtime metrics #1369
+242
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khauser
force-pushed
the
copilot/update-http-addon-rbac-permissions-again
branch
from
6e81c7e to
6058c96
Compare
khauser
changed the title
Copilot finished reviewing on behalf of
wozniakjan
November 18, 2025 09:23
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR secures the controller-runtime metrics endpoint by enabling built-in HTTPS and RBAC authentication/authorization, eliminating the need for kube-rbac-proxy. The metrics endpoint is changed from port 8080 to 8443 with TLS enabled.
- Changed metrics endpoint from HTTP on port 8080 to HTTPS on port 8443 with built-in authentication and authorization
- Added RBAC permissions for TokenReviews and SubjectAccessReviews to enable metrics endpoint authentication
- Added comprehensive E2E tests to verify secured metrics endpoint functionality
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| operator/main.go | Enables secure serving on metrics endpoint (port 8443) with authentication and authorization filters |
| config/operator/deployment.yaml | Updates metrics container port from 8080 to 8443 |
| config/operator/role.yaml | Adds permissions for authentication.k8s.io and authorization.k8s.io APIs required for metrics authentication |
| config/operator/role_binding.yaml | Adds system:auth-delegator ClusterRoleBinding and updates service account references |
| config/operator/metrics_service.yaml | Creates new Service resource to expose secured metrics endpoint |
| config/operator/metrics_reader_role.yaml | Defines ClusterRole for reading metrics via non-resource URLs |
| config/operator/kustomization.yaml | Includes new metrics service and reader role resources |
| tests/checks/operator_metrics/operator_metrics_test.go | Adds E2E tests to verify HTTPS metrics endpoint and RBAC authorization |
| tests/utils/setup_test.go | Fixes missing selector labels in opentelemetry-collector deployment |
| go.mod | Adds new dependencies for authentication/authorization features |
| go.sum | Updates checksums for new and updated dependencies |
| CHANGELOG.md | Documents removal of kube-rbac-proxy in v0.12.0 |
| .gitignore | Adds *.test to ignore compiled test binaries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| Status | Scanner |  Critical |
 High |
 Medium |
 Low |
Total (0) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
khauser
force-pushed
the
copilot/update-http-addon-rbac-permissions-again
branch
from
92b7817 to
775f96e
Compare
Signed-off-by: Karsten Ludwig Hauser <[email protected]>
…orization - Updated operator/main.go to configure metrics server with SecureServing on port 8443 - Added WithAuthenticationAndAuthorization filter for metrics endpoint - Updated deployment to use port 8443 for metrics - Created metrics service for operator - Added RBAC permissions for TokenReviews and SubjectAccessReviews - Created ClusterRole for metrics reader access - Added e2e test for operator metrics endpoint - Updated go.mod and go.sum with required dependencies Co-authored-by: khauser <[email protected]> Signed-off-by: Karsten Ludwig Hauser <[email protected]>
…ments Co-authored-by: khauser <[email protected]> Signed-off-by: Karsten Ludwig Hauser <[email protected]>
Added release notes for version 0.12.0, including improvements. Signed-off-by: Karsten Ludwig Hauser <[email protected]> Signed-off-by: Karsten Ludwig Hauser <[email protected]>
Signed-off-by: Karsten Ludwig Hauser <[email protected]>
khauser
force-pushed
the
copilot/update-http-addon-rbac-permissions-again
branch
3 times, most recently
from
8ee8e04 to
dbf3112
Compare
Signed-off-by: Karsten Ludwig Hauser <[email protected]>
khauser
force-pushed
the
copilot/update-http-addon-rbac-permissions-again
branch
from
dbf3112 to
2c85d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://book.kubebuilder.io/reference/metrics.html the metrics endpoint could be secured by the controller-runtime itself without utilizing kube-rbac-proxy.
Checklist
Fixes #1123