Rebuilt zipfiles, added basic python build script #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency since command is npx. Wrote build.py to facilitiate building and logging process.
…e versioning for zip files
…ter for the MAC packaging
…thub requirements
…mall edits to package.json and readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kelyvin
So I was able to get this to build, on linux anyway. I'm more comfortable with python, so I put together a python script to run the npx command and zip the files. This is current as of electron 12.0.10. I have tested the windows and linux versions...I don't use a mac, so can't test that.
I see you're looking for some help to do an automated build. I think what I would have to do from here is use the github api to do a commit. I've not done it before, but it looks straightforward from the examples.
Thanks,
Dale