Fix divide-by-zero error in hydrosnow #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update bmi functions for BMI 2 * minor clean up * use new hydro_initialize signature * draw random numbers as they are needed * use abs instead of fabs for integers * update implementation for new BMI initialize function * add CMAKE_MACOSX_RPATH to CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a divide-by-zero error in hydrosnow that caused a segmentation fault or floating point exception, depending on the system. A mass-balance check is done at the end of hydrosnow and if
Minputis zero, which happens to be the denominator, a floating-point error may be triggered.