Move the scheduling of end of the event loop to later in the loop #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
commented
Dec 22, 2025
| ApplicationMgr( | ||
| TopAlg=[failing_alg], | ||
| ExtSvc=[EventDataSvc()], | ||
| EvtMax=-1, # This is the important part here |
Member
Author
There was a problem hiding this comment.
Changing this to 1 (i.e. the exact number of events in the input file) gives the same behavior.
edit: Actually any positive value will preserve the behavior of not raising the error properly.
tmadlener
changed the title
Member
Author
|
As a side note: The only test that started failing with a first, slightly more naive move of the check, was |
The ExampleFailingSingleEvent test case should exit with a non-zero exit code, because there is an exception that is thrown during the event loop. However, since there is only a single event in the input file and we use EvtMax=-1 this is changed into a user requested ScheduleStop and a non-failing exit code.
Rather than doing it early in the event loop we do it at the latest point, where we still have access to all the necessary information. This way any exceptions or other failures should ake precedence over the ScheduleStop.
There is no easy (i.e. with standard CTest features) way to also check for a corresponding error message to ensure we got the "right" one.
jmcarcell
force-pushed
the
should-fail-evtmax-all
branch
from
282bc6a to
19b1889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ExampleFailingSingleEvent test case should exit with a non-zero exit code, because there is an exception that is thrown during the event loop. However, since there is only a single event in the input file and we use EvtMax=-1 this is changed into a user requested ScheduleStop and a non-failing exit code.
Moving the scheduling of this stop into the last action that is done in the
IOSvcgives precedence to other exit codes that happen earlier in the event loop inside Gaudi. Hence, we now get the expected failure.BEGINRELEASENOTES
ENDRELEASENOTES
Fixes #367