-
Notifications
You must be signed in to change notification settings - Fork 33
Add a key4hep-sim-reco environment and build it in an image
#794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tmadlener
wants to merge
10
commits into
main
Choose a base branch
from
reco-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cf95e9 to
a54f9a1
Compare
1b732ac to
f983aef
Compare
tmadlener
commented
Nov 10, 2025
key4hep-sim-reco environment and build it in an imagekey4hep-sim-reco environment and build it in an image
ee74a5b to
bcf02ef
Compare
This is the first step towards building Key4hep images that also contain software on top of the externals stack.
Necessary for proper variable expansion
Somehow this should automatically pick the correct one for each PR
Check and see if we avoid rebuilding this in the reco-sim package
bcf02ef to
3738d01
Compare
tmadlener
commented
Nov 29, 2025
Avoids building e.g. Geant4 another time on top of the externals image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
key4hep-sim-recoenvironment that skips building all generators and most of the machine learning adjacent toolsENDRELEASENOTES
sim-recoimage depend ondev-externalsimage in one workflow (currently not done for quicker turnaround on development)dev-externalspackages are properly re-used here to avoid having duplicated packages in the imageARM image forsim-recois not working becausesimsipmrelies on x86 intrinsice (at least on header), see e.g.: https://github.com/key4hep/key4hep-spack/actions/runs/17981415816/job/51148208590#step:8:1742