Skip to content

WIP: maybe delegate fixes #28826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisnojima-zoom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: maybe delegate fixes #28826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 45 additions & 10 deletions shared/ios/Keybase/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,18 @@ public class AppDelegate: ExpoAppDelegate, UNUserNotificationCenterDelegate, UID

var resignImageView: UIImageView?
var fsPaths: [String: String] = [:]
var shutdownTask: UIBackgroundTaskIdentifier = .invalid
private let shutdownTaskQueue = DispatchQueue(label: "com.keybase.appdelegate.shutdownTask")
private var _shutdownTask: UIBackgroundTaskIdentifier = .invalid
var shutdownTask: UIBackgroundTaskIdentifier {
get {
return shutdownTaskQueue.sync { _shutdownTask }
}
set {
shutdownTaskQueue.sync { _shutdownTask = newValue }
}
}
var iph: ItemProviderHelper?
var memoryWarningObserver: NSObjectProtocol?

public override func application(
_ application: UIApplication,
Expand All @@ -55,7 +65,7 @@ public class AppDelegate: ExpoAppDelegate, UNUserNotificationCenterDelegate, UID
KbSetInitialNotification(notificationDict)
}

NotificationCenter.default.addObserver(forName: UIApplication.didReceiveMemoryWarningNotification, object: nil, queue: .main) { [weak self] notification in
self.memoryWarningObserver = NotificationCenter.default.addObserver(forName: UIApplication.didReceiveMemoryWarningNotification, object: nil, queue: .main) { [weak self] notification in
NSLog("Memory warning received - deferring GC during React Native initialization")
// see if this helps avoid this crash
DispatchQueue.main.asyncAfter(deadline: .now() + 1.0) {
Expand Down Expand Up @@ -169,7 +179,9 @@ public class AppDelegate: ExpoAppDelegate, UNUserNotificationCenterDelegate, UID
self.resignImageView?.alpha = 0
self.resignImageView?.backgroundColor = rootView.backgroundColor
self.resignImageView?.image = UIImage(named: "LaunchImage")
self.window?.addSubview(self.resignImageView!)
if let resignImageView = self.resignImageView {
self.window?.addSubview(resignImageView)
}

UIApplication.shared.setMinimumBackgroundFetchInterval(UIApplication.backgroundFetchIntervalMinimum)
}
Expand All @@ -189,14 +201,20 @@ public class AppDelegate: ExpoAppDelegate, UNUserNotificationCenterDelegate, UID
}

public func dropInteraction(_ interaction: UIDropInteraction, performDrop session: UIDropSession) {
self.iph = nil

var items: [NSItemProvider] = []
session.items.forEach { item in items.append(item.itemProvider) }

self.iph = ItemProviderHelper(forShare: false, withItems: [items]) { [weak self] in
guard let self else { return }
let url = URL(string: "keybase://incoming-share")!
_ = self.application(UIApplication.shared, open: url, options: [:])
self.iph = nil
guard let self = self else { return }
defer { self.iph = nil }
do {
let url = URL(string: "keybase://incoming-share")!
_ = self.application(UIApplication.shared, open: url, options: [:])
} catch {
NSLog("ItemProviderHelper completion error: \(error)")
}
}
self.iph?.startProcessing()
}
Expand All @@ -220,7 +238,10 @@ public class AppDelegate: ExpoAppDelegate, UNUserNotificationCenterDelegate, UID
}

public override func application(_ application: UIApplication, didReceiveRemoteNotification notification: [AnyHashable: Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
guard let type = notification["type"] as? String else { return }
guard let type = notification["type"] as? String else {
completionHandler(.noData)
return
}
if type == "chat.newmessageSilent_2" {
DispatchQueue.global(qos: .default).async {
let convID = notification["c"] as? String
Expand Down Expand Up @@ -276,9 +297,19 @@ public class AppDelegate: ExpoAppDelegate, UNUserNotificationCenterDelegate, UID

public override func applicationWillTerminate(_ application: UIApplication) {
self.window?.rootViewController?.view.isHidden = true
self.iph = nil
Keybasego.KeybaseAppWillExit(PushNotifier())
}

deinit {
if let observer = memoryWarningObserver {
NotificationCenter.default.removeObserver(observer)
}
if shutdownTask != .invalid {
UIApplication.shared.endBackgroundTask(shutdownTask)
}
}

func hideCover() {
NSLog("hideCover: cancelling outstanding animations...")
self.resignImageView?.layer.removeAllAnimations()
Expand All @@ -288,7 +319,9 @@ public class AppDelegate: ExpoAppDelegate, UNUserNotificationCenterDelegate, UID
public override func applicationWillResignActive(_ application: UIApplication) {
NSLog("applicationWillResignActive: cancelling outstanding animations...")
self.resignImageView?.layer.removeAllAnimations()
self.resignImageView?.superview?.bringSubviewToFront(self.resignImageView!)
if let resignImageView = self.resignImageView, let superview = resignImageView.superview {
superview.bringSubviewToFront(resignImageView)
}
NSLog("applicationWillResignActive: rendering keyz screen...")
UIView.animate(withDuration: 0.3, delay: 0.1, options: .beginFromCurrentState) {
self.resignImageView?.alpha = 1
Expand All @@ -304,14 +337,15 @@ public class AppDelegate: ExpoAppDelegate, UNUserNotificationCenterDelegate, UID
self.resignImageView?.layer.removeAllAnimations()
NSLog("applicationDidEnterBackground: setting keyz screen alpha to 1.")
self.resignImageView?.alpha = 1
self.iph = nil

NSLog("applicationDidEnterBackground: notifying go.")
let requestTime = Keybasego.KeybaseAppDidEnterBackground()
NSLog("applicationDidEnterBackground: after notifying go.")

if requestTime && (self.shutdownTask == UIBackgroundTaskIdentifier.invalid) {
let app = UIApplication.shared
self.shutdownTask = app.beginBackgroundTask {
let taskIdentifier = app.beginBackgroundTask {
NSLog("applicationDidEnterBackground: shutdown task run.")
Keybasego.KeybaseAppWillExit(PushNotifier())
let task = self.shutdownTask
Expand All @@ -320,6 +354,7 @@ public class AppDelegate: ExpoAppDelegate, UNUserNotificationCenterDelegate, UID
self.shutdownTask = .invalid
}
}
self.shutdownTask = taskIdentifier

DispatchQueue.global(qos: .default).async {
Keybasego.KeybaseAppBeginBackgroundTask(PushNotifier())
Expand Down