NOMERGE: Use Uint8Array instead of Buffer everywhere #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
chrisnojima
commented
Oct 26, 2023
| } | ||
| first_pos = num_bufs - 1; | ||
| this._bufs[first_pos] = ret; | ||
| this._bufs = this._bufs.slice(first_pos); |
Author
There was a problem hiding this comment.
slice is deprecated https://nodejs.org/api/buffer.html#bufslicestart-end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MR to replace Buffer w/ Uint8Array. We don't have native Buffer support on all platforms on the keybase side so instead of doing that polyfill we instead switch to Uint8Array and just polyfill textdecoder/etc
Also fixes up tls errors in a test. Disables a retry test which fails for me also on master
Does not attempt to fixup purepack, so assumes @msgpack/msgpack