SPViz-OSGI improved #1
Conversation
NiklasRentzCAU
left a comment
NiklasRentzCAU
left a comment
There was a problem hiding this comment.
Due to all the formatting changes, this PR is very hard to read and the actual changes are not visible in some of the bigger files. Please re-do this PR without all the formatting changes so I can actually review this.
Some of the changes I did notice and left some individual comments in the changed lines. We can discuss how to continue with this PR in our next meeting.
| <buildCommand> | ||
| <name>org.eclipse.xtext.ui.shared.xtextBuilder</name> | ||
| <arguments> | ||
| </arguments> | ||
| </buildCommand> |
There was a problem hiding this comment.
Are these XtextBuilder and -nature now necessary due to the Maven Mojo you added or what do you need this for?
...kieler.spviz.osgi.generate/src/de/cau/cs/kieler/spviz/osgi/generate/ConfigAndExecuteCli.java
Outdated
Show resolved
Hide resolved
...ler.spviz.osgi.generate/src/de/cau/cs/kieler/spviz/osgi/generate/OsgiModelDataGenerator.java
Show resolved
Hide resolved
...ler.spviz.osgi.generate/src/de/cau/cs/kieler/spviz/osgi/generate/OsgiModelDataGenerator.java
Show resolved
Hide resolved
...ler.spviz.osgi.generate/src/de/cau/cs/kieler/spviz/osgi/generate/OsgiModelDataGenerator.java
Outdated
Show resolved
Hide resolved
...au.cs.kieler.spviz.osgi.generate/src/de/cau/cs/kieler/spviz/osgi/generate/mvn/MavenMojo.java
Show resolved
Hide resolved
...cs.kieler.spviz.osgi.generate/src/de/cau/cs/kieler/spviz/osgi/generate/ReadProjectFiles.java
Outdated
Show resolved
Hide resolved
| private void connectBundlesViaPackages() { | ||
| project.getPackages().forEach(p -> connectBundlesViaSinglePackageDependency(p)); | ||
| } | ||
|
|
||
| private void connectBundlesViaSinglePackageDependency(Package inputPackage) { | ||
| if (inputPackage.getConnectingPackageExportDependencyBundles().isEmpty()) { | ||
| LOGGER.log(System.Logger.Level.DEBUG, inputPackage.getName() + " has no exported package"); | ||
| return; | ||
| } | ||
|
|
||
| Bundle exportedBundle = inputPackage.getConnectingPackageExportDependencyBundles().get(0); | ||
| inputPackage.getConnectingPackageImportDependencyBundles().forEach(bundle -> { | ||
| bundle.getConnectedPackageDependencyBundles().add(exportedBundle); | ||
| getCommonProductForBundles(bundle, exportedBundle) | ||
| .forEach(product -> addOrUpdatePackageDependencyEdgeLabel(bundle, exportedBundle, product)); | ||
| }); | ||
|
|
||
| } |
There was a problem hiding this comment.
Let us talk about what you want to achieve here in our meeting, to me it seems that this re-wiring of connections is something that SPViz could do for you instead, probably by extending the DSL's functionality.
...cs.kieler.spviz.osgi.generate/src/de/cau/cs/kieler/spviz/osgi/generate/ReadProjectFiles.java
Outdated
Show resolved
Hide resolved
|
Very nice, this is much easier to understand now. PR looks good in general, I just left a few minor (unresolved) comments, once they are resolved/answered I am happy to merge this. |
2 participants
Package dependencies can now be shown. In case the OSGI-INF directory is not available, it can be generated from the jar.