[MAINTENANCE] Add tests for Controller package #954
Conversation
sebastian-meyer
changed the title
sebastian-meyer
added
⟳ maintenance
oliver-stoehr
force-pushed
the
ControllerTest
branch
from
f31a8fb to
eb756a2
Compare
sebastian-meyer
modified the milestones:
Kitodo.Presentation 5.0.0,
Kitodo.Presentation 5.1.0
oliver-stoehr
force-pushed
the
ControllerTest
branch
from
8ef040a to
2f9eb29
Compare
Co-authored-by: Sebastian Meyer <[email protected]>
| foreach ($databaseFixtures as $filePath) { | ||
| $this->importCSVDataSet($filePath); | ||
| } | ||
| $this->persistenceManager = $this->objectManager->get(PersistenceManager::class); |
There was a problem hiding this comment.
This seems to be the problem why the tests fail. $this->objectManager->get() throws the error Call to a member function get() on null, so $this->objectManager isn't initialized.
There was a problem hiding this comment.
This fails because as of version 12 the GeneralUtilityManager is used to get an instance of a class. However, if I change this, all tests fail. The response only contains an empty string. This must be related to the changes to version 12.
$this->persistenceManager = GeneralUtility::makeInstance(PersistenceManager::class);
There was a problem hiding this comment.
Yes, this fixed the issue. Now the tests are running for both, v11 and v12. Unfortunately, some of the tests fail...
|
More tests would be really useful. Therefore I appreciate this pull request. @oliver-stoehr, are you still working on it? I suggest to squash some of the commits (each commit should be complete and produce a working software). A rebase on main would be helpful, too. |
|
Tests created for:
In the StatisticsController in the MainAction, the test has so far failed because there was an error in the action. The remaining tests have otherwise passed. However, the problem now is that the new Typo3 version has changed the handling of the response objects. The interface |
|
Successor: #1708 |
5 participants
Tests for CalendarController will be added in a separate pull request.Update: Added tests for CalendarController in another commit.