Add serialize_writes option to ensure lines are sent in-order (resolves #361)#362
Open
edfletcher wants to merge 3 commits intokiwiirc:masterfrom
Open
Add serialize_writes option to ensure lines are sent in-order (resolves #361)#362edfletcher wants to merge 3 commits intokiwiirc:masterfrom
edfletcher wants to merge 3 commits intokiwiirc:masterfrom
Conversation
Author
|
For E2E testing, I am using this fix-fork already with my personal DRC instance(s), and it's working like a charm. Can't really think of a better way to E2E test it except for putting together a significant bot-and-mock-server-based test harness, which honestly I just don't have the time for. |
edfletcher
added a commit
to discord-relay-chat/drc
that referenced
this pull request
Jun 22, 2023
Until kiwiirc/irc-framework#362 can be merged upstream. Also includes the following fixes/updates: * fix bug in log search consumed by irc-responseWhois-full.js * fix join flood when isReconnect is true even though it should not be * improve os image initial setup for base image in Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #361
Includes an integration test that exercises both option values, demonstrating that - without
serialized_writes- lines that are purposefully reversed in order from that which the caller emitted them will be sent in that reverse order undesirably. When enablingserialized_writes, those writes are emitted in the order the caller intended.I'll squash all commits in this PR down into one before merging.