#392: fix creation of duplicate periodic ping timers#393
Open
squankytoast wants to merge 2 commits intokiwiirc:masterfrom
Open
#392: fix creation of duplicate periodic ping timers#393squankytoast wants to merge 2 commits intokiwiirc:masterfrom
squankytoast wants to merge 2 commits intokiwiirc:masterfrom
Conversation
Author
|
@Alpha4615 i tried to do this in a way that didn't tightly couple the client and connection objects or break encapsulation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #392
maintains a reference to the active periodic ping timer to prevent the creation of multiple ping timers if the client is already pinging when it receives a register event (i.e. you are connected to a znc which loses and regains its irc server connection)