Small change for the DataReload #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually set the selected day so as not to fire off the delegates didSelectCalendarDate method everytime the data reloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this great plug-in, I've found it extremely useful for a project i'm working on now.
I made this change locally on my copy of KalViewController:
instead of calling didSelectDate (since that will then call didSelectDate on the kalDelegate)
I think it makes more sense to tell the calendarView to set its date.
Im not sure if this is a change you'd want to add to master, or if the existing behavior was intentional. For my use case I really only need to know when a user-initiated date change occurs.
best,
Philip