-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Admin overview config overviews #6482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added mermaid graphic and content formatting testing
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Formatting testing
Trying a "blog" approach....
Minor edits
Link fixes
Minor edits
Co-authored-by: Evan Anderson <[email protected]>
Added Eventing config summaries
Put all config overviews in tables
Section title tweaks
Formatting edits
Organized sections
Formatting test
Removed temporary test
Section organization
Title shortening
Alphabetized rows in config summary tables
Link text edits in tables first columns
Minor edit to rebuild
Reviewer updates and mermaid edits
Mermaid testing
mermaid testing
Added text to introduce the graphic.
Intro and mermaid edits
Updated intro and mermaid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small nits, but I think we're getting close to done on this PR.
|
/assign |
Processed reviewer edits and mermaid tweaks
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iRaindrop The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updated Serving config table and mermaid fix
Formatting edits
mermaid tweaks
style try
hopeful mermaid fix
|
Ready for merge approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should really-actually be the last set of comments. It's looking very close, and I only noticed these items on a close reading of the preview page.
| Serving --> net-impl["Implements"] | ||
| net-impl --> net-istio & net-contour & net-gateway-api | ||
| Eventing --> event-impl["Implements"] | ||
| event-impl --> event-kafka & event-rabbitmq & event-nats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These arrows point the wrong way for "Implements" -- maybe "Provided by" or "Implemented with"?
| | [Default configurations](../serving/configuration/config-defaults.md) | `config-defaults` | Default resource values such as performance, hardware, and storage settings. | | ||
| | [Deployment resources](../serving/configuration/deployment.md) | `config-deployment` | Kubernetes deployment resources that back Knative services. | | ||
| | [Domain names](../serving/using-a-custom-domain.md) | `config-domain` | Configure and publish domains. | | ||
| | [High-availability](../serving/config-ha.md) | NA | Configure ensure that APIs stay operational if a disruption occurs. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "High Availability" and "Namespace exclusion" topics apply to both Serving and Eventing. I don't know if you want to repeat them, or pull them out into their own section.
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
mermaid directional tweaks
mermaid test
mermaid test
The overview of configuration tasks should parallell the Navigation.
Proposed Changes