Skip to content

Conversation

@iRaindrop
Copy link
Contributor

The overview of configuration tasks should parallell the Navigation.

Proposed Changes

  • Reformatted listing
  • Added mermaid graphic for testing

Added mermaid graphic and content formatting testing
@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6f45338
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/690bf0d136ed310008159080
😎 Deploy Preview https://deploy-preview-6482--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot requested review from nainaz and skonto October 30, 2025 18:42
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2025
@iRaindrop iRaindrop marked this pull request as draft October 30, 2025 18:43
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2025
Added Eventing config summaries
Put all config overviews in tables
Section title tweaks
Formatting edits
Organized sections
Formatting test
Removed temporary test
Section organization
Title shortening
Alphabetized rows in config summary tables
Link text edits in tables first columns
Minor edit to rebuild
Reviewer updates and mermaid edits
Mermaid testing
mermaid testing
Added text to introduce the graphic.
Intro and mermaid edits
Updated intro and mermaid
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, but I think we're getting close to done on this PR.

@evankanderson
Copy link
Member

/assign

Processed reviewer edits and mermaid tweaks
@knative-prow
Copy link

knative-prow bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iRaindrop
Once this PR has been reviewed and has the lgtm label, please ask for approval from evankanderson. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Updated Serving config table and mermaid fix
Formatting edits
hopeful mermaid fix
@iRaindrop iRaindrop marked this pull request as ready for review November 3, 2025 23:57
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025
@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo November 3, 2025 23:57
@iRaindrop
Copy link
Contributor Author

Ready for merge approval.

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really-actually be the last set of comments. It's looking very close, and I only noticed these items on a close reading of the preview page.

Comment on lines 40 to 43
Serving --> net-impl["Implements"]
net-impl --> net-istio & net-contour & net-gateway-api
Eventing --> event-impl["Implements"]
event-impl --> event-kafka & event-rabbitmq & event-nats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These arrows point the wrong way for "Implements" -- maybe "Provided by" or "Implemented with"?

| [Default configurations](../serving/configuration/config-defaults.md) | `config-defaults` | Default resource values such as performance, hardware, and storage settings. |
| [Deployment resources](../serving/configuration/deployment.md) | `config-deployment` | Kubernetes deployment resources that back Knative services. |
| [Domain names](../serving/using-a-custom-domain.md) | `config-domain` | Configure and publish domains. |
| [High-availability](../serving/config-ha.md) | NA | Configure ensure that APIs stay operational if a disruption occurs. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "High Availability" and "Namespace exclusion" topics apply to both Serving and Eventing. I don't know if you want to repeat them, or pull them out into their own section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants