Skip to content

Conversation

@AEnterprise
Copy link
Contributor

small space saving optimalization (more to follow, just splitting out)

bigest impact here is not including the test songs. it feels wrong to include the rest of the test folder but it seems some of these are used for artisan commands. These probably shouldn't live in the test folder but that can be tackled separately later

@AEnterprise AEnterprise force-pushed the cleanup-excess-files branch from 9ae310d to 4188ff1 Compare August 31, 2025 10:10
@phanan
Copy link
Member

phanan commented Aug 31, 2025

TBH I don't think this is important, and I'd prefer keeping them instead (even the test files) just in case some more tech-savvy users want to dig into the code.

@AEnterprise
Copy link
Contributor Author

well right now it's a mix of some files are kept, some are not. and wouldn't a tech savvy user be better off just cloning the repo instead of messing around in a docker container without any dev tools? half the useful files are already gone and with the git information removed you can't even get a proper patch out of the docker container. this should be ment to run, not to develop.

if you want people to develop inside a docker container then a separate image with proper tooling would be far superior

and especially the songs is a bunch of wasted download that 99.99% of users will never benefit from nor even know it exists, slowing down downloads and increasing the storage used

@phanan
Copy link
Member

phanan commented Aug 31, 2025

You're right.

@phanan
Copy link
Member

phanan commented Aug 31, 2025

Btw there's a couple more directories we can get rid of:

image

Do you think you can update the PR accordingly?

@AEnterprise AEnterprise force-pushed the cleanup-excess-files branch from 16d9679 to 935c366 Compare August 31, 2025 14:22
@AEnterprise
Copy link
Contributor Author

added the new folders, also updated the gitignore to ignore all .env files in this repo instead of individual ones

@phanan phanan merged commit 84800f8 into koel:master Aug 31, 2025
1 check passed
@phanan
Copy link
Member

phanan commented Aug 31, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants