-
Notifications
You must be signed in to change notification settings - Fork 60
remove some unneeded files from the docker container #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9ae310d to
4188ff1
Compare
|
TBH I don't think this is important, and I'd prefer keeping them instead (even the test files) just in case some more tech-savvy users want to dig into the code. |
|
well right now it's a mix of some files are kept, some are not. and wouldn't a tech savvy user be better off just cloning the repo instead of messing around in a docker container without any dev tools? half the useful files are already gone and with the git information removed you can't even get a proper patch out of the docker container. this should be ment to run, not to develop. if you want people to develop inside a docker container then a separate image with proper tooling would be far superior and especially the songs is a bunch of wasted download that 99.99% of users will never benefit from nor even know it exists, slowing down downloads and increasing the storage used |
Co-authored-by: Phan An <[email protected]>
Co-authored-by: Phan An <[email protected]>
Co-authored-by: Phan An <[email protected]>
|
You're right. |
16d9679 to
935c366
Compare
|
added the new folders, also updated the gitignore to ignore all .env files in this repo instead of individual ones |
|
Thanks! |

small space saving optimalization (more to follow, just splitting out)
bigest impact here is not including the test songs. it feels wrong to include the rest of the test folder but it seems some of these are used for artisan commands. These probably shouldn't live in the test folder but that can be tackled separately later