Махлонов Дмитрий #195
Open
Махлонов Дмитрий #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlazProject
reviewed
Jan 18, 2025
| @@ -0,0 +1,57 @@ | |||
| namespace ResultTools; | |||
|
|
|||
| public class Result<T> | |||
There was a problem hiding this comment.
Если пытаться избавиться от Result<None>, то можно посмотреть как сделаны Task и Task<T>. Тогда бы ошибка и IsSuccess вынеслись в Result, а Result<T>:Result принёс ещё и Value. Но в этом случае придётся немного переписать (дописать) методы расширений. Тогда пропадёт такая особенность, что в метод передаётся None при вызове Then(none =>)
|
|
||
| var format = splittedPath.Last(); | ||
|
|
||
| var reader = readers.FirstOrDefault(r => r.SupportedFormats().Contains(format.ToLower())); |
There was a problem hiding this comment.
Если обращение происходит часто, лучше обернуть все ридеры в словарь на этапе инициализации. Так как линейное итерирование может потребовать много времени.
There was a problem hiding this comment.
мне кажется конкретно в этом проекте обращение проходит достаточно редко, а способ более удобный, чем словарь
TagCloudResult/TagCloudTests/CloudLayouterTests/CircularCloudLayouterTests.cs
Outdated
Show resolved
Hide resolved
GlazProject
reviewed
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.