Skip to content

Conversation

@aufi
Copy link
Member

@aufi aufi commented Aug 15, 2025

E2E API tests are executed with working-directory: go-konveyor-tests, adding that path also to upload analysis logs step.

Summary by CodeRabbit

  • Chores

    • Updated CI workflow to upload test artifacts from the checked-out test workspace, improving consistency of archived test outputs. No user-facing changes.
  • Tests

    • Adjusted artifact upload source for end-to-end API integration tests to ensure analysis outputs are reliably captured for debugging and traceability.

@coderabbitai
Copy link

coderabbitai bot commented Aug 15, 2025

Walkthrough

Updated the GitHub Actions workflow to change the artifact upload source path in the e2e-api-integration-tests job from analysis/tmp_output to /home/runner/work/ci/ci/go-konveyor-tests/tmp_output. No other workflow parameters or public interfaces were modified.

Changes

Cohort / File(s) Summary
CI Workflow
.github/workflows/global-ci-bundle.yml
In the e2e-api-integration-tests job, updated the "Upload analysis tests output" artifact step to use source path /home/runner/work/ci/ci/go-konveyor-tests/tmp_output instead of analysis/tmp_output.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hop through YAML fields with care,
Moved a path from here to there.
Artifacts now know where to go,
CI hums softly, steady flow.
Thump-thump—merge and onward, ho! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 92376c2 and 285270c.

📒 Files selected for processing (1)
  • .github/workflows/global-ci-bundle.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/global-ci-bundle.yml
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch analysis-logs-upload-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/global-ci-bundle.yml (1)

372-379: Optional: set working-directory on the upload step for symmetry and resilience.

Setting working-directory to go-konveyor-tests and using a relative path keeps the step consistent with prior steps and avoids hardcoding the repo folder name in multiple places.

       - name: Upload analysis tests output
         if: always()
         uses: actions/upload-artifact@v4
+        working-directory: go-konveyor-tests
         with:
           name: analysis-tests-output
           include-hidden-files: true
-          path: go-konveyor-tests/analysis/tmp_output
+          path: analysis/tmp_output
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 504ab2a and fb88a67.

📒 Files selected for processing (1)
  • .github/workflows/global-ci-bundle.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/global-ci-bundle.yml (1)

378-378: Correct source path for analyzer logs.

Updating the artifact path to go-konveyor-tests/analysis/tmp_output matches the earlier working-directory used for running the tests. This should fix the missing logs.

aufi added 2 commits August 15, 2025 16:02
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
@aufi aufi marked this pull request as draft August 15, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant