-
Notifications
You must be signed in to change notification settings - Fork 13
Fix analyzer logs upload in global-ci-bundle.yml #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Marek Aufart <[email protected]>
WalkthroughUpdated the GitHub Actions workflow to change the artifact upload source path in the e2e-api-integration-tests job from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/global-ci-bundle.yml (1)
372-379: Optional: set working-directory on the upload step for symmetry and resilience.Setting working-directory to go-konveyor-tests and using a relative path keeps the step consistent with prior steps and avoids hardcoding the repo folder name in multiple places.
- name: Upload analysis tests output if: always() uses: actions/upload-artifact@v4 + working-directory: go-konveyor-tests with: name: analysis-tests-output include-hidden-files: true - path: go-konveyor-tests/analysis/tmp_output + path: analysis/tmp_output
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/global-ci-bundle.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/global-ci-bundle.yml (1)
378-378: Correct source path for analyzer logs.Updating the artifact path to go-konveyor-tests/analysis/tmp_output matches the earlier working-directory used for running the tests. This should fix the missing logs.
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
E2E API tests are executed with
working-directory: go-konveyor-tests, adding that path also to upload analysis logs step.Summary by CodeRabbit
Chores
Tests